Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mute JMXFetch Shutdown in progress error #8068

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Mute JMXFetch Shutdown in progress error #8068

merged 2 commits into from
Jan 9, 2025

Conversation

ygree
Copy link
Contributor

@ygree ygree commented Dec 7, 2024 •
edited by jira bot
Loading

What Does This Do

Mute JMXFetch Shutdown in progress error

Motivation

Additional Notes

Contributor Checklist

Jira ticket: APMS-14162

@ygree ygree added the type: bug label Dec 7, 2024
@ygree ygree self-assigned this Dec 7, 2024
@ygree ygree requested a review from a team as a code owner December 7, 2024 01:07
@ygree ygree requested a review from PerfectSlayer December 7, 2024 01:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2024 •
edited
Loading

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2024

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@ygree ygree added the comp: jmx-fetch JMX fetch label Dec 7, 2024
@pr-commenter
Copy link

pr-commenter bot commented Dec 7, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master ygree/mute-jmxfetch-shutdown-err
git_commit_date 1736352030 1736360551
git_commit_sha 73f194e 4219371
release_version 1.45.0-SNAPSHOT~73f194e3ea 1.44.0-SNAPSHOT~4219371ba8
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1736363212 1736363212
ci_job_id 759115968 759115968
ci_pipeline_id 52476216 52476216
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 9 performance improvements and 12 performance regressions! Performance is the same for 35 metrics, 7 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:iast:Agent.start worse
[+32.831ms; +48.658ms] or [+2.776%; +4.114%]		 1.223s 1.183s
scenario:startup:insecure-bank:iast:GlobalTracer worse
[+57.226ms; +59.464ms] or [+23.144%; +24.049%]		 305.611ms 247.265ms
scenario:startup:insecure-bank:iast:Remote Config better
[-55.522µs; -17.643µs] or [-8.140%; -2.587%]		 645.542µs 682.124µs
scenario:startup:insecure-bank:iast:Telemetry better
[-1.322ms; -0.981ms] or [-15.093%; -11.199%]		 7.608ms 8.760ms
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:GlobalTracer worse
[+53.598ms; +62.960ms] or [+21.530%; +25.291%]		 307.226ms 248.946ms
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:Telemetry better
[-1.473ms; -0.941ms] or [-16.764%; -10.709%]		 7.580ms 8.787ms
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:GlobalTracer worse
[+55.401ms; +61.304ms] or [+22.357%; +24.739%]		 306.155ms 247.802ms
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:Telemetry better
[-1.385ms; -0.762ms] or [-15.962%; -8.781%]		 7.605ms 8.679ms
scenario:startup:insecure-bank:tracing:GlobalTracer worse
[+56.518ms; +65.977ms] or [+21.863%; +25.522%]		 319.761ms 258.514ms
scenario:startup:insecure-bank:tracing:Remote Config better
[-72.869µs; -30.874µs] or [-9.951%; -4.216%]		 680.398µs 732.269µs
scenario:startup:petclinic:appsec:GlobalTracer worse
[+57.951ms; +65.156ms] or [+22.741%; +25.569%]		 316.381ms 254.828ms
scenario:startup:petclinic:iast:Agent.start worse
[+37.032ms; +45.275ms] or [+3.132%; +3.830%]		 1.223s 1.182s
scenario:startup:petclinic:iast:GlobalTracer worse
[+58.770ms; +60.763ms] or [+23.790%; +24.597%]		 306.805ms 247.038ms
scenario:startup:petclinic:iast:Telemetry better
[-1.263ms; -0.848ms] or [-14.421%; -9.684%]		 7.701ms 8.756ms
scenario:startup:petclinic:profiling:Agent.start worse
[+37.370ms; +48.044ms] or [+2.928%; +3.765%]		 1.319s 1.276s
scenario:startup:petclinic:profiling:GlobalTracer worse
[+58.507ms; +63.571ms] or [+15.702%; +17.061%]		 433.645ms 372.606ms
scenario:startup:petclinic:profiling:Telemetry better
[-618.440µs; -218.211µs] or [-7.642%; -2.696%]		 7.675ms 8.093ms
scenario:startup:petclinic:tracing:Agent.start worse
[+32.368ms; +40.713ms] or [+3.066%; +3.856%]		 1.092s 1.056s
scenario:startup:petclinic:tracing:BytebuddyAgent better
[-21.732ms; -16.896ms] or [-3.046%; -2.368%]		 694.105ms 713.418ms
scenario:startup:petclinic:tracing:GlobalTracer worse
[+60.070ms; +61.959ms] or [+23.445%; +24.182%]		 317.231ms 256.216ms
scenario:startup:petclinic:tracing:Remote Config better
[-46.511µs; -27.850µs] or [-6.471%; -3.875%]		 681.577µs 718.757µs
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~4219371ba8, baseline=1.45.0-SNAPSHOT~73f194e3ea

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1066464
Total [baseline] (8.636 s) : 0, 8635910
Agent [candidate] (1.099 s) : 0, 1099416
Total [candidate] (8.698 s) : 0, 8697666
section iast
Agent [baseline] (1.183 s) : 0, 1182736
Total [baseline] (9.238 s) : 0, 9237517
Agent [candidate] (1.223 s) : 0, 1223481
Total [candidate] (9.218 s) : 0, 9218366
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.192 s) : 0, 1192207
Total [baseline] (9.226 s) : 0, 9225944
Agent [candidate] (1.226 s) : 0, 1226458
Total [candidate] (9.195 s) : 0, 9195282
section iast_TELEMETRY_OFF
Agent [baseline] (1.184 s) : 0, 1184324
Total [baseline] (9.21 s) : 0, 9209553
Agent [candidate] (1.218 s) : 0, 1217862
Total [candidate] (9.205 s) : 0, 9205073
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent iast 1.183 s 116.272 ms (10.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.192 s 125.743 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.184 s 117.86 ms (11.1%)
Total tracing 8.636 s -
Total iast 9.238 s 601.607 ms (7.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.226 s 590.034 ms (6.8%)
Total iast_TELEMETRY_OFF 9.21 s 573.643 ms (6.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.099 s -
Agent iast 1.223 s 124.065 ms (11.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.226 s 127.042 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.218 s 118.446 ms (10.8%)
Total tracing 8.698 s -
Total iast 9.218 s 520.7 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.195 s 497.616 ms (5.7%)
Total iast_TELEMETRY_OFF 9.205 s 507.407 ms (5.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~4219371ba8, baseline=1.45.0-SNAPSHOT~73f194e3ea

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (720.605 ms) : 0, 720605
BytebuddyAgent [candidate] (700.834 ms) : 0, 700834
GlobalTracer [baseline] (258.514 ms) : 0, 258514
GlobalTracer [candidate] (319.761 ms) : 0, 319761
AppSec [baseline] (55.529 ms) : 0, 55529
AppSec [candidate] (55.012 ms) : 0, 55012
Remote Config [baseline] (732.269 µs) : 0, 732
Remote Config [candidate] (680.398 µs) : 0, 680
Telemetry [baseline] (15.955 ms) : 0, 15955
Telemetry [candidate] (9.268 ms) : 0, 9268
section iast
BytebuddyAgent [baseline] (830.942 ms) : 0, 830942
BytebuddyAgent [candidate] (816.507 ms) : 0, 816507
GlobalTracer [baseline] (247.265 ms) : 0, 247265
GlobalTracer [candidate] (305.611 ms) : 0, 305611
AppSec [baseline] (58.389 ms) : 0, 58389
AppSec [candidate] (57.348 ms) : 0, 57348
IAST [baseline] (21.717 ms) : 0, 21717
IAST [candidate] (21.983 ms) : 0, 21983
Remote Config [baseline] (682.124 µs) : 0, 682
Remote Config [candidate] (645.542 µs) : 0, 646
Telemetry [baseline] (8.76 ms) : 0, 8760
Telemetry [candidate] (7.608 ms) : 0, 7608
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (838.598 ms) : 0, 838598
BytebuddyAgent [candidate] (818.041 ms) : 0, 818041
GlobalTracer [baseline] (248.946 ms) : 0, 248946
GlobalTracer [candidate] (307.226 ms) : 0, 307226
AppSec [baseline] (58.512 ms) : 0, 58512
AppSec [candidate] (57.877 ms) : 0, 57877
IAST [baseline] (21.481 ms) : 0, 21481
IAST [candidate] (21.203 ms) : 0, 21203
Remote Config [baseline] (674.917 µs) : 0, 675
Remote Config [candidate] (660.52 µs) : 0, 661
Telemetry [baseline] (8.787 ms) : 0, 8787
Telemetry [candidate] (7.58 ms) : 0, 7580
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (833.065 ms) : 0, 833065
BytebuddyAgent [candidate] (810.319 ms) : 0, 810319
GlobalTracer [baseline] (247.802 ms) : 0, 247802
GlobalTracer [candidate] (306.155 ms) : 0, 306155
AppSec [baseline] (58.274 ms) : 0, 58274
AppSec [candidate] (58.59 ms) : 0, 58590
IAST [baseline] (20.825 ms) : 0, 20825
IAST [candidate] (20.785 ms) : 0, 20785
Remote Config [baseline] (657.02 µs) : 0, 657
Remote Config [candidate] (645.111 µs) : 0, 645
Telemetry [baseline] (8.679 ms) : 0, 8679
Telemetry [candidate] (7.605 ms) : 0, 7605
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~4219371ba8, baseline=1.45.0-SNAPSHOT~73f194e3ea

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055798
Total [baseline] (10.472 s) : 0, 10472149
Agent [candidate] (1.092 s) : 0, 1092339
Total [candidate] (10.495 s) : 0, 10494824
section appsec
Agent [baseline] (1.195 s) : 0, 1194713
Total [baseline] (10.713 s) : 0, 10713489
Agent [candidate] (1.233 s) : 0, 1232547
Total [candidate] (10.746 s) : 0, 10745846
section iast
Agent [baseline] (1.182 s) : 0, 1182182
Total [baseline] (11.008 s) : 0, 11008191
Agent [candidate] (1.223 s) : 0, 1223335
Total [candidate] (10.983 s) : 0, 10983465
section profiling
Agent [baseline] (1.276 s) : 0, 1276107
Total [baseline] (10.938 s) : 0, 10937831
Agent [candidate] (1.319 s) : 0, 1318814
Total [candidate] (10.87 s) : 0, 10870218
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent appsec 1.195 s 138.915 ms (13.2%)
Agent iast 1.182 s 126.384 ms (12.0%)
Agent profiling 1.276 s 220.309 ms (20.9%)
Total tracing 10.472 s -
Total appsec 10.713 s 241.34 ms (2.3%)
Total iast 11.008 s 536.043 ms (5.1%)
Total profiling 10.938 s 465.682 ms (4.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.092 s -
Agent appsec 1.233 s 140.208 ms (12.8%)
Agent iast 1.223 s 130.997 ms (12.0%)
Agent profiling 1.319 s 226.476 ms (20.7%)
Total tracing 10.495 s -
Total appsec 10.746 s 251.022 ms (2.4%)
Total iast 10.983 s 488.641 ms (4.7%)
Total profiling 10.87 s 375.395 ms (3.6%) 
gantt
    title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~4219371ba8, baseline=1.45.0-SNAPSHOT~73f194e3ea

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.418 ms) : 0, 713418
BytebuddyAgent [candidate] (694.105 ms) : 0, 694105
GlobalTracer [baseline] (256.216 ms) : 0, 256216
GlobalTracer [candidate] (317.231 ms) : 0, 317231
AppSec [baseline] (55.995 ms) : 0, 55995
AppSec [candidate] (54.617 ms) : 0, 54617
Remote Config [baseline] (718.757 µs) : 0, 719
Remote Config [candidate] (681.577 µs) : 0, 682
Telemetry [baseline] (14.467 ms) : 0, 14467
Telemetry [candidate] (11.913 ms) : 0, 11913
section appsec
BytebuddyAgent [baseline] (734.765 ms) : 0, 734765
BytebuddyAgent [candidate] (715.423 ms) : 0, 715423
GlobalTracer [baseline] (254.828 ms) : 0, 254828
GlobalTracer [candidate] (316.381 ms) : 0, 316381
AppSec [baseline] (170.721 ms) : 0, 170721
AppSec [candidate] (167.684 ms) : 0, 167684
IAST [baseline] (20.219 ms) : 0, 20219
IAST [candidate] (19.337 ms) : 0, 19337
Remote Config [baseline] (663.028 µs) : 0, 663
Remote Config [candidate] (653.226 µs) : 0, 653
Telemetry [baseline] (8.563 ms) : 0, 8563
Telemetry [candidate] (8.93 ms) : 0, 8930
section iast
BytebuddyAgent [baseline] (831.064 ms) : 0, 831064
BytebuddyAgent [candidate] (814.633 ms) : 0, 814633
GlobalTracer [baseline] (247.038 ms) : 0, 247038
GlobalTracer [candidate] (306.805 ms) : 0, 306805
AppSec [baseline] (58.132 ms) : 0, 58132
AppSec [candidate] (57.509 ms) : 0, 57509
IAST [baseline] (21.53 ms) : 0, 21530
IAST [candidate] (22.253 ms) : 0, 22253
Remote Config [baseline] (663.924 µs) : 0, 664
Remote Config [candidate] (653.571 µs) : 0, 654
Telemetry [baseline] (8.756 ms) : 0, 8756
Telemetry [candidate] (7.701 ms) : 0, 7701
section profiling
BytebuddyAgent [baseline] (702.794 ms) : 0, 702794
BytebuddyAgent [candidate] (691.522 ms) : 0, 691522
GlobalTracer [baseline] (372.606 ms) : 0, 372606
GlobalTracer [candidate] (433.645 ms) : 0, 433645
AppSec [baseline] (54.175 ms) : 0, 54175
AppSec [candidate] (53.358 ms) : 0, 53358
Remote Config [baseline] (664.71 µs) : 0, 665
Remote Config [candidate] (652.329 µs) : 0, 652
Telemetry [baseline] (8.093 ms) : 0, 8093
Telemetry [candidate] (7.675 ms) : 0, 7675
ProfilingAgent [baseline] (95.894 ms) : 0, 95894
ProfilingAgent [candidate] (92.717 ms) : 0, 92717
Profiling [baseline] (95.918 ms) : 0, 95918
Profiling [candidate] (92.741 ms) : 0, 92741
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-01-08T18:37:02 2025-01-08T18:44:00
git_branch master ygree/mute-jmxfetch-shutdown-err
git_commit_date 1736352030 1736360551
git_commit_sha 73f194e 4219371
release_version 1.45.0-SNAPSHOT~73f194e3ea 1.44.0-SNAPSHOT~4219371ba8
start_time 2025-01-08T18:36:48 2025-01-08T18:43:47
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1736362193 1736362193
ci_job_id 759115969 759115969
ci_pipeline_id 52476216 52476216
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~4219371ba8, baseline=1.45.0-SNAPSHOT~73f194e3ea
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.357 ms) : 1337, 1377
.   : milestone, 1357,
appsec (1.742 ms) : 1717, 1767
.   : milestone, 1742,
appsec_no_iast (1.744 ms) : 1720, 1768
.   : milestone, 1744,
iast (1.488 ms) : 1464, 1511
.   : milestone, 1488,
profiling (1.511 ms) : 1486, 1537
.   : milestone, 1511,
tracing (1.495 ms) : 1471, 1520
.   : milestone, 1495,
section candidate
no_agent (1.322 ms) : 1303, 1341
.   : milestone, 1322,
appsec (1.739 ms) : 1715, 1762
.   : milestone, 1739,
appsec_no_iast (1.74 ms) : 1715, 1764
.   : milestone, 1740,
iast (1.463 ms) : 1440, 1485
.   : milestone, 1463,
profiling (1.558 ms) : 1534, 1581
.   : milestone, 1558,
tracing (1.502 ms) : 1477, 1526
.   : milestone, 1502,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.357 ms [1.337 ms, 1.377 ms] -
appsec 1.742 ms [1.717 ms, 1.767 ms] 385.11 µs (28.4%)
appsec_no_iast 1.744 ms [1.72 ms, 1.768 ms] 386.848 µs (28.5%)
iast 1.488 ms [1.464 ms, 1.511 ms] 130.648 µs (9.6%)
profiling 1.511 ms [1.486 ms, 1.537 ms] 154.358 µs (11.4%)
tracing 1.495 ms [1.471 ms, 1.52 ms] 138.283 µs (10.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.322 ms [1.303 ms, 1.341 ms] -
appsec 1.739 ms [1.715 ms, 1.762 ms] 416.604 µs (31.5%)
appsec_no_iast 1.74 ms [1.715 ms, 1.764 ms] 417.52 µs (31.6%)
iast 1.463 ms [1.44 ms, 1.485 ms] 140.773 µs (10.6%)
profiling 1.558 ms [1.534 ms, 1.581 ms] 235.727 µs (17.8%)
tracing 1.502 ms [1.477 ms, 1.526 ms] 179.582 µs (13.6%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~4219371ba8, baseline=1.45.0-SNAPSHOT~73f194e3ea
    dateFormat X
    axisFormat %s
section baseline
no_agent (370.348 µs) : 350, 391
.   : milestone, 370,
iast (488.042 µs) : 466, 510
.   : milestone, 488,
iast_FULL (650.837 µs) : 629, 672
.   : milestone, 651,
iast_GLOBAL (516.226 µs) : 495, 538
.   : milestone, 516,
iast_HARDCODED_SECRET_DISABLED (486.791 µs) : 465, 509
.   : milestone, 487,
iast_INACTIVE (453.579 µs) : 432, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (482.777 µs) : 460, 505
.   : milestone, 483,
tracing (447.475 µs) : 426, 469
.   : milestone, 447,
section candidate
no_agent (370.066 µs) : 350, 390
.   : milestone, 370,
iast (486.287 µs) : 465, 508
.   : milestone, 486,
iast_FULL (643.158 µs) : 622, 665
.   : milestone, 643,
iast_GLOBAL (520.722 µs) : 498, 544
.   : milestone, 521,
iast_HARDCODED_SECRET_DISABLED (487.795 µs) : 466, 509
.   : milestone, 488,
iast_INACTIVE (448.518 µs) : 428, 469
.   : milestone, 449,
iast_TELEMETRY_OFF (475.461 µs) : 454, 497
.   : milestone, 475,
tracing (445.234 µs) : 425, 466
.   : milestone, 445,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.348 µs [349.709 µs, 390.987 µs] -
iast 488.042 µs [466.497 µs, 509.588 µs] 117.694 µs (31.8%)
iast_FULL 650.837 µs [629.247 µs, 672.426 µs] 280.488 µs (75.7%)
iast_GLOBAL 516.226 µs [494.685 µs, 537.767 µs] 145.878 µs (39.4%)
iast_HARDCODED_SECRET_DISABLED 486.791 µs [464.899 µs, 508.683 µs] 116.443 µs (31.4%)
iast_INACTIVE 453.579 µs [432.057 µs, 475.101 µs] 83.231 µs (22.5%)
iast_TELEMETRY_OFF 482.777 µs [460.462 µs, 505.093 µs] 112.429 µs (30.4%)
tracing 447.475 µs [426.348 µs, 468.603 µs] 77.127 µs (20.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.066 µs [350.007 µs, 390.125 µs] -
iast 486.287 µs [464.748 µs, 507.826 µs] 116.221 µs (31.4%)
iast_FULL 643.158 µs [621.701 µs, 664.616 µs] 273.092 µs (73.8%)
iast_GLOBAL 520.722 µs [497.884 µs, 543.559 µs] 150.656 µs (40.7%)
iast_HARDCODED_SECRET_DISABLED 487.795 µs [466.484 µs, 509.107 µs] 117.729 µs (31.8%)
iast_INACTIVE 448.518 µs [427.832 µs, 469.203 µs] 78.451 µs (21.2%)
iast_TELEMETRY_OFF 475.461 µs [454.373 µs, 496.549 µs] 105.395 µs (28.5%)
tracing 445.234 µs [424.515 µs, 465.952 µs] 75.167 µs (20.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master ygree/mute-jmxfetch-shutdown-err
git_commit_date 1736352030 1736360551
git_commit_sha 73f194e 4219371
release_version 1.45.0-SNAPSHOT~73f194e3ea 1.44.0-SNAPSHOT~4219371ba8
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1736362751 1736362751
ci_job_id 759115971 759115971
ci_pipeline_id 52476216 52476216
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~4219371ba8, baseline=1.45.0-SNAPSHOT~73f194e3ea
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.19 s) : 15190000, 15190000
.   : milestone, 15190000,
appsec (15.059 s) : 15059000, 15059000
.   : milestone, 15059000,
iast (18.715 s) : 18715000, 18715000
.   : milestone, 18715000,
iast_GLOBAL (17.725 s) : 17725000, 17725000
.   : milestone, 17725000,
profiling (15.367 s) : 15367000, 15367000
.   : milestone, 15367000,
tracing (15.317 s) : 15317000, 15317000
.   : milestone, 15317000,
section candidate
no_agent (14.727 s) : 14727000, 14727000
.   : milestone, 14727000,
appsec (14.804 s) : 14804000, 14804000
.   : milestone, 14804000,
iast (18.989 s) : 18989000, 18989000
.   : milestone, 18989000,
iast_GLOBAL (17.746 s) : 17746000, 17746000
.   : milestone, 17746000,
profiling (15.191 s) : 15191000, 15191000
.   : milestone, 15191000,
tracing (14.894 s) : 14894000, 14894000
.   : milestone, 14894000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.19 s [15.19 s, 15.19 s] -
appsec 15.059 s [15.059 s, 15.059 s] -131.0 ms (-0.9%)
iast 18.715 s [18.715 s, 18.715 s] 3.525 s (23.2%)
iast_GLOBAL 17.725 s [17.725 s, 17.725 s] 2.535 s (16.7%)
profiling 15.367 s [15.367 s, 15.367 s] 177.0 ms (1.2%)
tracing 15.317 s [15.317 s, 15.317 s] 127.0 ms (0.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.727 s [14.727 s, 14.727 s] -
appsec 14.804 s [14.804 s, 14.804 s] 77.0 ms (0.5%)
iast 18.989 s [18.989 s, 18.989 s] 4.262 s (28.9%)
iast_GLOBAL 17.746 s [17.746 s, 17.746 s] 3.019 s (20.5%)
profiling 15.191 s [15.191 s, 15.191 s] 464.0 ms (3.2%)
tracing 14.894 s [14.894 s, 14.894 s] 167.0 ms (1.1%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~4219371ba8, baseline=1.45.0-SNAPSHOT~73f194e3ea
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
.   : milestone, 1478,
appsec (2.37 ms) : 2328, 2413
.   : milestone, 2370,
iast (2.109 ms) : 2056, 2163
.   : milestone, 2109,
iast_GLOBAL (2.154 ms) : 2100, 2208
.   : milestone, 2154,
profiling (2.461 ms) : 2273, 2648
.   : milestone, 2461,
tracing (1.964 ms) : 1922, 2005
.   : milestone, 1964,
section candidate
no_agent (1.48 ms) : 1468, 1491
.   : milestone, 1480,
appsec (2.348 ms) : 2307, 2389
.   : milestone, 2348,
iast (2.104 ms) : 2052, 2157
.   : milestone, 2104,
iast_GLOBAL (2.147 ms) : 2095, 2200
.   : milestone, 2147,
profiling (2.444 ms) : 2203, 2684
.   : milestone, 2444,
tracing (1.936 ms) : 1896, 1976
.   : milestone, 1936,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.478 ms [1.467 ms, 1.49 ms] -
appsec 2.37 ms [2.328 ms, 2.413 ms] 892.159 µs (60.4%)
iast 2.109 ms [2.056 ms, 2.163 ms] 631.169 µs (42.7%)
iast_GLOBAL 2.154 ms [2.1 ms, 2.208 ms] 675.68 µs (45.7%)
profiling 2.461 ms [2.273 ms, 2.648 ms] 982.302 µs (66.4%)
tracing 1.964 ms [1.922 ms, 2.005 ms] 485.324 µs (32.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.48 ms [1.468 ms, 1.491 ms] -
appsec 2.348 ms [2.307 ms, 2.389 ms] 868.185 µs (58.7%)
iast 2.104 ms [2.052 ms, 2.157 ms] 624.715 µs (42.2%)
iast_GLOBAL 2.147 ms [2.095 ms, 2.2 ms] 667.568 µs (45.1%)
profiling 2.444 ms [2.203 ms, 2.684 ms] 963.775 µs (65.1%)
tracing 1.936 ms [1.896 ms, 1.976 ms] 456.099 µs (30.8%)

@ygree ygree enabled auto-merge (squash) December 7, 2024 02:17
PerfectSlayer
PerfectSlayer reviewed Dec 9, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this log be error in the first place?
Maybe warn at best, and dumping exception stacktrace only in debug mode.
WDYT?

dd-java-agent/agent-jmxfetch/src/main/java/datadog/trace/agent/jmxfetch/JMXFetch.java Outdated
@@ -142,9 +142,16 @@ public void run() {
if (!appConfig.getExitWatcher().shouldExit()) {
try {
final int result = app.run();
log.error("jmx collector exited with result: {}", result);
if (result != 0) {
log.error("jmx collector exited with result: {}", result);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
log.error("jmx collector exited with result: {}", result);
log.error("jmx collector exited with error code: {}", result);

@ygree ygree force-pushed the ygree/mute-jmxfetch-shutdown-err branch from 4219371 to 5019d47 Compare January 8, 2025 18:25
@ygree ygree requested a review from PerfectSlayer January 8, 2025 18:26
PerfectSlayer
PerfectSlayer approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! 

@ygree ygree merged commit 0632027 into master Jan 9, 2025
149 of 150 checks passed
@ygree ygree deleted the ygree/mute-jmxfetch-shutdown-err branch January 9, 2025 13:09
@github-actions github-actions bot added this to the 1.46.0 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

Assignees

@ygree ygree

Labels
comp: jmx-fetch JMX fetch type: bug
Projects
None yet
Milestone
1.46.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ygree @PerfectSlayer